Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix] Fixed DNS Provider List not visible for non-admin users #1337

Merged
merged 1 commit into from
Nov 4, 2022
Merged

[hotfix] Fixed DNS Provider List not visible for non-admin users #1337

merged 1 commit into from
Nov 4, 2022

Conversation

grolu
Copy link
Contributor

@grolu grolu commented Nov 4, 2022 •
edited
Loading

What this PR does / why we need it:
Regular users cannot access controllerregistration resources. Need to add changed controllerregistration resources for DNS Providers to list of allowed resources.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fixed DNS Provider List not visible for regular users (non-operators)

@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Nov 4, 2022
@gardener-robot
Copy link

@grolu You need rebase this pull request with latest master branch. Please check.

@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Nov 4, 2022
@grolu grolu changed the base branch from master to hotfix-1.61 November 4, 2022 13:26
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 4, 2022
petersutter
petersutter approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/rebase Needs git rebase needs/review Needs review labels Nov 4, 2022
@grolu grolu merged commit 8dbc3a6 into hotfix-1.61 Nov 4, 2022
@grolu grolu deleted the fix/hotfix_dns_resources branch November 4, 2022 13:35
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petersutter petersutter petersutter approved these changes

@holgerkoser holgerkoser Awaiting requested review from holgerkoser

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grolu @gardener-robot @petersutter @gardener-robot-ci-1